Bug 43693

Summary:

sizeInBytes should be removed

Product:

WebKit

Reporter:

Gregg Tavares <gman>

Component:

WebGL

Assignee:

Zhenyao Mo <zmo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, dglazkov, kbr, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	levin: review+, zmo: commit-queue-

Description Gregg Tavares 2010-08-08 11:01:52 PDT

WebGLContext.sizeInBytes is not part of the WebGL standard and should be removed.

One of the conformance tests and a couple of the samples were using this deprecated function. I've fixed those but it seems like sizeInBytes should be removed so people don't mistakenly use it in the future.

Comment 1 Zhenyao Mo 2010-08-09 13:16:48 PDT

Created attachment 63920 [details]
patch

Comment 2 Zhenyao Mo 2010-08-09 13:21:06 PDT

forget to mention: tests are synced with khronos.

Comment 3 Kenneth Russell 2010-08-09 13:33:53 PDT

Looks good to me. Consider putting sizeInBytes into webgl-test.js for better code sharing.

Comment 4 Zhenyao Mo 2010-08-09 13:36:33 PDT

Committed r64998: <http://trac.webkit.org/changeset/64998>