Bug 43693

Summary: sizeInBytes should be removed
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, kbr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch levin: review+, zmo: commit-queue-

Gregg Tavares
Reported 2010-08-08 11:01:52 PDT
WebGLContext.sizeInBytes is not part of the WebGL standard and should be removed. One of the conformance tests and a couple of the samples were using this deprecated function. I've fixed those but it seems like sizeInBytes should be removed so people don't mistakenly use it in the future.
Attachments
patch (11.00 KB, patch)
2010-08-09 13:16 PDT, Zhenyao Mo 		levin: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-08-09 13:16:48 PDT
Created attachment 63920 [details] patch
Zhenyao Mo
Comment 2 2010-08-09 13:21:06 PDT
forget to mention: tests are synced with khronos.
Kenneth Russell
Comment 3 2010-08-09 13:33:53 PDT
Looks good to me. Consider putting sizeInBytes into webgl-test.js for better code sharing.
Zhenyao Mo
Comment 4 2010-08-09 13:36:33 PDT
Committed r64998: <http://trac.webkit.org/changeset/64998>
Note You need to log in before you can comment on or make changes to this bug.