Bug 43679

Summary: First word on a line doesn’t hyphenate properly
Product: WebKit Reporter: mitz
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: data:text/html,<div style="font-size: 96px; border: solid; width: 220px; -webkit-hyphens: auto; -webkit-hyphenate-locale: 'en_US'">declination</div>
Attachments:
Description Flags
Include the character at lastSpace in the string passed to lastHyphenLocation() andersca: review+

mitz
Reported 2010-08-07 13:46:30 PDT
tryHyphenating() assumes that the character at lastSpace is a space character, and doesn’t include it in the string passed to lastHyphenLocation(). This is not always the case, such as when the current word is the first on a line. Patch forthcoming.
Attachments
Include the character at lastSpace in the string passed to lastHyphenLocation() (116.86 KB, patch)
2010-08-07 13:52 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-08-07 13:46:53 PDT
<rdar://problem/8285090>
mitz
Comment 2 2010-08-07 13:52:45 PDT
Created attachment 63826 [details] Include the character at lastSpace in the string passed to lastHyphenLocation()
mitz
Comment 3 2010-08-07 14:42:20 PDT
Fixed in <http://trac.webkit.org/changeset/64920>.
Note You need to log in before you can comment on or make changes to this bug.