| Summary: | [Qt] Flash content can not be displayed by Symbian Flash Player | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hui Huang <hui_huang> | ||||||
| Component: | Plug-ins | Assignee: | Hui Huang <hui_huang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Critical | CC: | andersca, commit-queue, cshu, eric, hausmann, hui_huang, ossy, yael | ||||||
| Priority: | P3 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | S60 Emulator | ||||||||
| OS: | Other | ||||||||
| Attachments: |
|
||||||||
Created attachment 63770 [details]
Proposed patch
When plug-in is being created, m_windowRect is not updated in updatePluginWidget because the parent of PluginView is not set:
void PluginView::updatePluginWidget()
{
if (!parent())
return;
...
Plug-in gets wrong window size (both height and width are 0) on setwindow. Flash content is not displayed. Calling updatePluginWidget() after plug-in is successfully loaded in PluginView::setParent fixed the problem. The proposed patch was tested successfully on S60 emulator.
Per Yael's suggestion, I'm checking recent changesets to see if this has already been fixed. Tried changesets 61505, 62159, 62184, and 62185 with no luck. I will try Webkit trunk. If this has been fixed in trunk, need to find out by which patch. Comment on attachment 63770 [details]
Proposed patch
rs=me.
Eric, thanks a lot for reviewing the patch. Comment on attachment 63770 [details] Proposed patch Clearing flags on attachment: 63770 Committed r65249: <http://trac.webkit.org/changeset/65249> All reviewed patches have been landed. Closing bug. |
Created attachment 63751 [details] Simplified test content for test case reduction Flash content is not displayed by Symiban Flash Player on Nokia S60 Simulator. I'm using Webkit with Qt. Simplified test content is attached as test_case.zip.