Summary: | Add mac-cyrillic to the list of encodings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | DOM | Assignee: | Adele Peterson <adele> | ||||
Status: | VERIFIED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
URL: | http://www.sbrf.ru/ | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2005-08-09 13:13:04 PDT
The make-charset-table issue may have been obsoleted by switching to ICU (I'm not really sure, though). I have filed a request to add mac-cyrillic as an ICU Jitterbug 4859 (<http://dev.icu-project.org/cgi-bin/ icu-bugs>). All you have to do is add "maccyrillic" without the hyphen. Non-alphanumeric characters are ignored when doing the table match and only the first item in each table is allowed to contain them (because it's used in reverse-mapping an encoding to its name). So fixing this bug is as simple as adding that element to the table. Created attachment 5072 [details] proposed patch Thank you, I didn't grasp the difference between the first and subsequent elements :) I'm left wondering about rdar://3327157 (x-mac-ukrainian should be mapped to MacCyrillic) - could it be a workaround for some problem that no longer exists? A layout test is probably not necessary here (there are no tests for the presence of charset aliases) - correct me if I'm wrong. Comment on attachment 5072 [details]
proposed patch
r=me
I've committed this. |