Bug 43611

Summary:

noembed should respect whether plugins are enabled

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2010-08-06 00:10:40 PDT

noembed should respect whether plugins are enabled

Comment 1 Adam Barth 2010-08-06 00:12:43 PDT

Created attachment 63702 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-08-06 10:36:20 PDT

Comment on attachment 63702 [details]
Patch

WebCore/html/HTMLTreeBuilder.h:195
 +      static bool scriptEnabled(Frame* frame);
No need for the argument name.

Please file a bug with the HTML5 spec.

Comment 3 Eric Seidel (no email) 2010-08-06 10:36:45 PDT

Oh, it's possible to test this via DRT.  With layoutTestController.overridePreference()

Comment 4 Eric Seidel (no email) 2010-08-06 10:37:04 PDT

Comment on attachment 63702 [details]
Patch

This should have a layout test. :)

Comment 5 WebKit Commit Bot 2010-08-06 10:58:34 PDT

Comment on attachment 63702 [details]
Patch

Clearing flags on attachment: 63702

Committed r64858: <http://trac.webkit.org/changeset/64858>

Comment 6 WebKit Commit Bot 2010-08-06 10:58:39 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Eric Seidel (no email) 2010-08-06 11:01:51 PDT

Sigh.  This is an age-old bug: https://bugs.webkit.org/show_bug.cgi?id=32679