Bug 43603

Summary: Add form client for injected bundle code
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Updated patch andersca: review+

Description Sam Weinig 2010-08-05 19:37:51 PDT 
Add form client for injected bundle code.
Comment 1 Sam Weinig 2010-08-05 20:06:35 PDT 
Created attachment 63682 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-05 20:10:13 PDT 
Attachment 63682 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133:  Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134:  Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135:  Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136:  Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-05 20:53:57 PDT 
Created attachment 63685 [details]
Updated patch

Oops, wrong patch uploaded.
Comment 4 WebKit Review Bot 2010-08-05 20:57:56 PDT 
Attachment 63685 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133:  Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134:  Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135:  Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136:  Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2010-08-06 11:54:31 PDT 
Landed in r64862.