Bug 43577

Summary: Add script world API for injected bundles
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Sam Weinig
Reported 2010-08-05 14:22:17 PDT
Add script world API for injected bundles
Attachments
Patch (23.29 KB, patch)
2010-08-05 14:27 PDT, Sam Weinig 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-05 14:27:07 PDT
Created attachment 63636 [details] Patch
WebKit Review Bot
Comment 2 2010-08-05 14:28:29 PDT
Attachment 63636 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:53: More than one command on the same line [whitespace/newline] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:61: More than one command on the same line [whitespace/newline] [4] WebKit2/WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-08-05 14:32:26 PDT
Landed in r64788.
Note You need to log in before you can comment on or make changes to this bug.