Bug 43562

Summary:

[Qt] Temporary files should not be created in the current directory

Product:

WebKit

Reporter:

Simon Hausmann <hausmann>

Component:

Platform

Assignee:

Simon Hausmann <hausmann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hui_huang, laszlo.gombos

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Simon Hausmann 2010-08-05 08:31:53 PDT

Currently the way FileSystemQt.cpp creates temporary files makes them end up in the current directory.

We should be using the dedicated temporary directory on the system instead.

Comment 1 Simon Hausmann 2010-08-05 08:36:23 PDT

The use of the current directory creates problems on Symbian (with different drives, etc.) and in general the system temporary directory is the better place, as it may be subject to cleanup (gc on system startup) and it has better permissions in place.

Comment 2 Simon Hausmann 2010-08-05 08:37:13 PDT

Created attachment 63596 [details]
Patch

Comment 3 Laszlo Gombos 2010-08-05 08:50:26 PDT

Comment on attachment 63596 [details]
Patch

looks good to me, r+.

Comment 4 WebKit Commit Bot 2010-08-05 22:09:00 PDT

Comment on attachment 63596 [details]
Patch

Clearing flags on attachment: 63596

Committed r64816: <http://trac.webkit.org/changeset/64816>

Comment 5 WebKit Commit Bot 2010-08-05 22:09:05 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Simon Hausmann 2010-08-10 06:39:45 PDT

Revision r64816 cherry-picked into qtwebkit-2.1 with commit 195b286c999effb1c2e675ce35c3936c5cea946d