Summary: | Chromium: isindex tests timeout after r64712 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, mihaip | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2010-08-05 01:43:00 PDT
More timeout suppressions: BUGWK43543 DEBUG : fast/parser/residual-style-dom.html = TIMEOUT BUGWK43543 LINUX MAC DEBUG : fast/parser/residual-style-hang.html = TIMEOUT Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt Committed r64751 Created attachment 63821 [details]
Faster failing isindex tests
Comment on attachment 63821 [details]
Faster failing isindex tests
Thanks.
I happened to be running all the layout tests with --slowest, and I noticed that isindex-with-no-form-base-href.html and isindex-formdata.html both took 30 seconds, since they trigger a DRT timeout with the HTML5 builder. The attached patch still has them fail, but in <1 second (since it actually checks for the things that are no longer there with the HTML 5 parser). Is something like this worth committing as a stopgap? As for the tests themselves, isindex-formdata.html is definitely no longer valid with the HTML5 tree builder, since <isindex> elements inside <form> is supposed to be ignored (and is tested by LayoutTests/html5lib/resources/isindex.dat), so perhaps it could be deleted altogether. isindex-with-no-form-base-href.html seems tricker, since it has a naked <isindex> element, which per http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#isindex should generate a wrapping <form> (and does). However, that form has no action attribute, and I guess pre-HTML5 builder, the generated (empty string) form action was resolved against the <base href>, but that's no longer the case. I can't find anything in the HTML5 spec that defines the behavior either way, but Adam or Eric are probably more familiar with that. I think it's worth landing. The results of these tests match Minefield and the spec, as far as I can tell. Comment on attachment 63821 [details] Faster failing isindex tests Clearing flags on attachment: 63821 Committed r64944: <http://trac.webkit.org/changeset/64944> All reviewed patches have been landed. Closing bug. |