Summary: | [Qt] Input mode states are not reset after entering a password field | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Leong <david.leong> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | david.leong, hausmann, laszlo.gombos | ||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | S60 Hardware | ||||||
OS: | S60 3rd edition | ||||||
Attachments: |
|
Description
David Leong
2010-08-04 18:39:35 PDT
Made a small mistake with the description., the use case is clicking a <input type='password'> field, which sets the input mode to 'hidden'. Next click on a <textarea> and the text area input will be stuck in the password mode. Created attachment 63528 [details]
proposed change to reset input modes
The bug happens when the user clicks on a input field with a specific type then clicking on a text area. Because the input hints are never reset the text area inherits the wrong input hints.
The fix is to reset the state and set all flags from scratch.
Looks good to me. Comment on attachment 63528 [details]
proposed change to reset input modes
r=me. I'll land it manually together with a unit test.
Committed r64725: <http://trac.webkit.org/changeset/64725> cherry-picked into qtwebkit-4.6 with commit bbff6182e525fcf58dbc7426a1fbbf8f31588214 Revision r64725 cherry-picked into qtwebkit-2.1 with commit b0aea678e59f43c4fcc556d736da887452be5aad |