Summary: | Add DOM Node wrapper class for injected bundle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-08-04 16:57:31 PDT
Created attachment 63610 [details]
Patch
Attachment 63610 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:51: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:52: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:53: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:54: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:58: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:59: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:60: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 11 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63610 [details] Patch > Index: WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp > =================================================================== > --- WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp (revision 0) > +++ WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp (revision 0) > + > +static DOMHandleCache& domHandleCache() > +{ > + static DOMHandleCache cache; This should use DEFINE_STATIC_LOCAL to avoid an exit time destructor. > +PassRefPtr<InjectedBundleNodeHandle> InjectedBundleNodeHandle::get(Node* node) I prefer the name getOrCreate here. Landed in http://trac.webkit.org/changeset/64778. |