Bug 43500 – Update ANGLE to r352

• Component: WebGL
• Status: RESOLVED FIXED

[Kenneth Russell]

We need to update the copy of ANGLE checked in to WebKit to r352 to track the version used in Chromium. Recent API changes in the shader validator are preventing the patch in https://bugs.webkit.org/show_bug.cgi?id=42405 from building on Chromium.

[Chris Marrin]

I don't think this bug should block https://bugs.webkit.org/show_bug.cgi?id=42405. We can still land the integration with WebCore without making this change

[Kenneth Russell]

(In reply to comment #1)
> I don't think this bug should block https://bugs.webkit.org/show_bug.cgi?id=42405. We can still land the integration with WebCore without making this change

That is true, but the Chromium project could not then update to a newer WebKit without updating both the ANGLE in WebKit and the use of ANGLE in WebCore. Any public API changes to the shader validator will cause this problem. I'd like to address the known outstanding issue before checking in the initial code to WebCore which uses ANGLE. I'll have a patch up in a few minutes so it should not block 42405 for long.

[Kenneth Russell]

Created attachment 63478 [details]
Patch

Updated ANGLE to r352 (July 26, 2010). Built WebKit to test.

[WebKit Review Bot]

Attachment 63478 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
er/Initialize.cpp:330:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:331:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:332:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:333:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:335:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:336:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:337:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:338:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:340:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:341:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:342:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:343:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:361:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:392:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:393:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:394:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:395:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:397:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:398:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:399:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:400:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:424:  One space before end of line comments  [whitespace/comments] [5]
ANGLE/src/compiler/Initialize.cpp:425:  One space before end of line comments  [whitespace/comments] [5]
ANGLE/src/compiler/Initialize.cpp:426:  One space before end of line comments  [whitespace/comments] [5]
ANGLE/src/compiler/Initialize.cpp:594:  Missing space before ( in switch(  [whitespace/parens] [5]
ANGLE/src/compiler/Initialize.cpp:598:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:599:  Should have a space between // and comment  [whitespace/comments] [4]
ANGLE/src/compiler/Initialize.cpp:600:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 48 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dimitri Glazkov (Google)]

Comment on attachment 63478 [details]
Patch

rs=me.

[Kenneth Russell]

Committed r64665: <http://trac.webkit.org/changeset/64665>