Bug 43495

Summary:

Lay the groundwork for saving/restoring page session state to WK2

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

New Bugs

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Brady Eidson

Reported 2010-08-04 11:30:45 PDT

Lay the groundwork for saving/restoring page session state to WK2

Attachments
Patch (23.36 KB, patch) 2010-08-04 11:35 PDT, Brady Eidson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2010-08-04 11:35:11 PDT

Created attachment 63471 [details] Patch

Sam Weinig

Comment 2 2010-08-04 11:38:57 PDT

Comment on attachment 63471 [details] Patch Please add to the vcproj as well.

WebKit Review Bot

Comment 3 2010-08-04 11:39:40 PDT

Attachment 63471 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKData.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/API/C/WKData.cpp:29: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/API/C/WKAPICast.h:56: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:57: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:58: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:60: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:62: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:63: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:64: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:65: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:73: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:74: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:75: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:77: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:79: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:80: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:81: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:82: More than one command on the same line [whitespace/newline] [4] Total errors found: 18 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 4 2010-08-04 11:55:37 PDT

Committed r64662: <http://trac.webkit.org/changeset/64662>

Note You need to log in before you can comment on or make changes to this bug.