fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Since StyleChange class removes the styles that are already present at the position, fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle are redundant and should be removed.

Note that fontColorChangesComputedStyle uses visited dependent information, and it's a potential security hole.

[Ryosuke Niwa]

Created attachment 63415 [details]
Patch

[Justin Garcia]

Comment on attachment 63415 [details]
Patch

r=me assuming you verified that that bug that Beth mentioned didn't regress.

[Justin Garcia]

Ah, I just read your email, thanks Ryosuke!

[Ryosuke Niwa]

Created attachment 63421 [details]
Patch

[Ryosuke Niwa]

(In reply to comment #3)
> Ah, I just read your email, thanks Ryosuke!

Justin, I just figured out that my change will cause redundant font tag to be added in the reproduction steps Beth sent me.  Although this won't the bug Beth fixed to reappear, I added a fix for this problem which is basically to add a work-around for the 28282 just as we did for StyleChange. I also added a test case.  Sorry for the trouble.  I always realize problems with my patch after I posted it on bugzilla :(

[Justin Garcia]

Comment on attachment 63421 [details]
Patch

Looks good, r=me

[Ryosuke Niwa]

(In reply to comment #6)
> (From update of attachment 63421 [details])
> Looks good, r=me

Thanks for the review again!

[Ryosuke Niwa]

Committed r65019: <http://trac.webkit.org/changeset/65019>