Bug 43460 – prepare-ChangeLog fails mysteriously if curl doesn't support ssl

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aaron Boodman]

It ends up printing "Bug $bugNumber has no bug description. Maybe you set wrong bug ID?", which isn't really the problem.

[Aaron Boodman]

Created attachment 63408 [details]
Patch

[Joseph Pecoraro]

This patch looks good to me, however the output might be confusing to
users. I think it would be fine with an added line of output like:

  "Could not get the bug description for bug $bugNumber"

Other than that I'm good with it. I'm CCing Eric, who has some more
experience with Scripts (and he originally wrote the code above using
curl) to see if he can sanity check it as well.

Thanks for the quick improvement Aaron!

[Eric Seidel (no email)]

Comment on attachment 63408 [details]
Patch

Looks FANTASTIC.  Thank you.

Maybe we should move to using some built in perl way of fetching the bug instead?  I don't know what built-in perl SSL solutions there are.

[Eric Seidel (no email)]

Comment on attachment 63408 [details]
Patch

I CC'd other folks who have perl experience in case they have bright ideas.  But looks good to me.

[Joseph Pecoraro]

(In reply to comment #4)
> (From update of attachment 63408 [details])
> I CC'd other folks who have perl experience in case they have
> bright ideas.  But looks good to me.

Thanks for the quick reply! I CC'd someone as well.

@Aaron, I still suggest adding the additional line out output to clarify
what went wrong. It also hints at why curl was used in the first place.

[Aaron Boodman]

Committed r64654: <http://trac.webkit.org/changeset/64654>