Bug 43444

Summary: PLATFORM(CF) is false on Windows in JavaScriptCore
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: aroben, mrowe, nlawrence
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Patch mrowe: review+

Description Geoffrey Garen 2010-08-03 14:13:18 PDT
PLATFORM(CF) is defined in WebCore/config.h, which means that JavaScriptCore is not in on the fun.

We'd like JavaScriptCore to know about PLATFORM(CF) so it can use the CF GC activity callback.

I'm not immediately sure what the best way is to distinguish Windows builds with CF from those without. WebCore uses the WIN_CAIRO #define, which is probably not right for JavaScriptCore, and is even a little weird for WebCore.
Comment 1 Geoffrey Garen 2010-08-03 14:38:46 PDT
Created attachment 63378 [details]
Comment 2 Mark Rowe (bdash) 2010-08-03 14:42:57 PDT
Comment on attachment 63378 [details]

The presence of #define WTF_USE_WININET 1 in Platform.h is very odd, since WebCore/config.h undefines that macro.  Not really relevant to your patch, but it’s strange.

Your changes to WebCore/WebCore.xcodeproj/project.pbxproj should be excluded from this patch since they’re not relevant.

Comment 3 Geoffrey Garen 2010-08-03 15:04:41 PDT
Committed r64591: <http://trac.webkit.org/changeset/64591>