Bug 43444

Summary: PLATFORM(CF) is false on Windows in JavaScriptCore
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, mrowe, nlawrence
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mrowe: review+

Geoffrey Garen
Reported 2010-08-03 14:13:18 PDT
PLATFORM(CF) is defined in WebCore/config.h, which means that JavaScriptCore is not in on the fun. We'd like JavaScriptCore to know about PLATFORM(CF) so it can use the CF GC activity callback. I'm not immediately sure what the best way is to distinguish Windows builds with CF from those without. WebCore uses the WIN_CAIRO #define, which is probably not right for JavaScriptCore, and is even a little weird for WebCore.
Attachments
Patch (6.24 KB, patch)
2010-08-03 14:38 PDT, Geoffrey Garen 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2010-08-03 14:38:46 PDT
Created attachment 63378 [details] Patch
Mark Rowe (bdash)
Comment 2 2010-08-03 14:42:57 PDT
Comment on attachment 63378 [details] Patch The presence of #define WTF_USE_WININET 1 in Platform.h is very odd, since WebCore/config.h undefines that macro. Not really relevant to your patch, but it’s strange. Your changes to WebCore/WebCore.xcodeproj/project.pbxproj should be excluded from this patch since they’re not relevant. r=me
Geoffrey Garen
Comment 3 2010-08-03 15:04:41 PDT
Committed r64591: <http://trac.webkit.org/changeset/64591>
Note You need to log in before you can comment on or make changes to this bug.