Bug 43442

Summary: [Qt] QtWebKit does not link on Windows CE 6 due to sqlite3 problem
Product: WebKit Reporter: Joerg Bornemann <joerg.bornemann>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, joerg.bornemann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Description Flags
fix #1
eric: review-
fix #2 none

Description Joerg Bornemann 2010-08-03 13:35:49 PDT
QtWebKit does not link on Windows CE 6 due to sqlite3 problem
This affects Qt 4.6.3 and above.

The exact linker error is:
sqlite3.obj : error LNK2019: unresolved external symbol localtime_s referenced in function localtimeOffset

The function localtime_s doesn't exist in the WinCE 6 MSVCRT.

To fix this, we could just add a
to WebKit.pro in the sqlite scope.

This is even ok for WinCE 5.
Comment 1 Joerg Bornemann 2010-08-03 13:37:08 PDT
The corresponding Qt issue is http://bugreports.qt.nokia.com/browse/QTBUG-5120
Comment 2 Joerg Bornemann 2010-08-06 01:44:24 PDT
Created attachment 63705 [details]
fix #1

fixes the linker error by defining HAVE_LOCALTIME_S=0 in WebCore.pro
Comment 3 Eric Seidel (no email) 2010-08-06 14:13:23 PDT
Comment on attachment 63705 [details]
fix #1

Every patch requires a ChangeLog.  This one is also not made from a WebKit checkout.
Comment 4 Joerg Bornemann 2010-08-11 05:20:41 PDT
Created attachment 64101 [details]
fix #2

attempt #2. Now diffing from WebKit checkout and with ChangeLog.
Comment 5 Holger Freyther 2010-09-07 01:07:42 PDT
Comment on attachment 64101 [details]
fix #2

Asking the cq to land it.
Comment 6 WebKit Commit Bot 2010-09-07 01:29:16 PDT
Comment on attachment 64101 [details]
fix #2

Clearing flags on attachment: 64101

Committed r66865: <http://trac.webkit.org/changeset/66865>
Comment 7 WebKit Commit Bot 2010-09-07 01:29:20 PDT
All reviewed patches have been landed.  Closing bug.