Bug 43427

Summary: [Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebKit QtAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43428    
Attachments:
Description Flags
patch 1 none

Luiz Agostini
Reported 2010-08-03 09:24:57 PDT
This is the last preparation step before going into actual WebKit2 popup menu API. Now that the popup menu classes in WebCore/platform has changed a lot (bug 42592), QtAbstarctWebPopup became redundant and unnecessary. There is no need to keep any Qt specific code for popup menus in WebCore/platform and some layering violations may be removed. No changes are needed in platform plugins interface. This change will not affect plugins.
Attachments
patch 1 (51.68 KB, patch)
2010-08-05 12:24 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-08-05 12:24:05 PDT
Created attachment 63616 [details] patch 1
WebKit Commit Bot
Comment 2 2010-08-06 04:16:06 PDT
Comment on attachment 63616 [details] patch 1 Clearing flags on attachment: 63616 Committed r64829: <http://trac.webkit.org/changeset/64829>
WebKit Commit Bot
Comment 3 2010-08-06 04:16:10 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-08-06 07:30:33 PDT
http://trac.webkit.org/changeset/64829 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/64829 http://trac.webkit.org/changeset/64830
Note You need to log in before you can comment on or make changes to this bug.