Summary: | Fix rendering of speech button and enable layout tests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Satish Sampath <satish> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jorlow, tkent | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 39485 | ||||||||||
Attachments: |
|
Description
Satish Sampath
2010-08-03 09:18:29 PDT
Created attachment 63338 [details]
Patch
Comment on attachment 63338 [details] Patch > There is one known issue for chromium-linux where the spin button doesn't appear if speech is enabled, I'll work on that in a separate patch. We shouldn't add expectations which we know it's incorrect. test_expectations.txt should have an entry of LINUX numberandspeech. GTK has no spinbutton implementation yet. I think we shouldn't add expectation files for GTK numberandspeech and keep it skipped. Created attachment 63428 [details]
Patch
Removed test expectations for input-appearance-numberandspeech.html on chromium-linux and gtk since <input type='number'> is not fully implemented on these platforms yet. Updated the skipped list accordingly.
Comment on attachment 63428 [details]
Patch
Ok.
Created attachment 63437 [details]
Patch
I just remembered that the speech input feature flag is not enabled for mac and gtk builds, so it doesn't make sense to enable the tests for those platforms. Hence I am removing the changes to mac/Skipped and gtk/Skipped along with the new expectations.
Comment on attachment 63437 [details]
Patch
r=me
Comment on attachment 63437 [details] Patch Rejecting patch 63437 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Jeremy Orlow', u'--force']" exit_code: 255 Last 500 characters of output: rance-searchandspeech.html patching file LayoutTests/fast/speech/input-appearance-speechbutton.html patching file LayoutTests/platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9 BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9. Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662. Full output: http://queues.webkit.org/results/3643330 Comment on attachment 63437 [details] Patch Clearing flags on attachment: 63437 Committed r64746: <http://trac.webkit.org/changeset/64746> All reviewed patches have been landed. Closing bug. |