Bug 43418

Summary: [GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal none

Mario Sanchez Prada
Reported 2010-08-03 06:19:46 PDT
It would be needed to make some extra checks at AccessibilityObject::visiblePositionRangeForRange to make sure toRenderText() function is called with valid parameters, that is, a RenderObject returning 'true when calling to its isText() method. This check is needed because current code doesn't do it and could be executed with RenderObjects other than instances of the RenderText subclass, resulting in failures such as the one in the following stack trace: http://webkit-bots.igalia.com/i386/svn_64534.core-when_1280823420-_-who_testatk-_-why_11.26739.trace.html I'm now building WK with a patch for this. Will attach it as soon as I tested it.
Attachments
Patch proposal (3.14 KB, patch)
2010-08-03 06:50 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2010-08-03 06:46:16 PDT
Adding Xan to CC
Mario Sanchez Prada
Comment 2 2010-08-03 06:50:28 PDT
Created attachment 63331 [details] Patch proposal This patch just adds the needed checks that should have been added before, along with fix for bug 25677 (my fault)
Xan Lopez
Comment 3 2010-08-03 07:09:27 PDT
Comment on attachment 63331 [details] Patch proposal OK
WebKit Commit Bot
Comment 4 2010-08-05 00:55:55 PDT
Comment on attachment 63331 [details] Patch proposal Clearing flags on attachment: 63331 Committed r64721: <http://trac.webkit.org/changeset/64721>
WebKit Commit Bot
Comment 5 2010-08-05 00:56:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.