Bug 43391

Summary: Factor out PendingScript and protect its members
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 40934    
Bug Blocks: 20710    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tony Gentilcore
Reported 2010-08-02 16:27:57 PDT
Factor out PendingScript and protect its members
Attachments
Patch (19.54 KB, patch)
2010-08-02 16:32 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.70 KB, patch)
2010-08-04 17:13 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.51 KB, patch)
2010-08-06 10:16 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-08-02 16:32:58 PDT
Created attachment 63275 [details] Patch
Adam Barth
Comment 2 2010-08-02 18:03:16 PDT
Comment on attachment 63275 [details] Patch WebCore/dom/PendingScript.h:44 + class PendingScript : public CachedResourceClient, Noncopyable { Noncopyable should probably be the first base class, not that it really matters. WebCore/dom/PendingScript.h:69 + virtual void notifyFinished(CachedResource*) Please move to implementation file. It can't be inlined anyway.
Tony Gentilcore
Comment 3 2010-08-04 17:10:56 PDT
(In reply to comment #2) > (From update of attachment 63275 [details]) > WebCore/dom/PendingScript.h:44 > + class PendingScript : public CachedResourceClient, Noncopyable { > Noncopyable should probably be the first base class, not that it really matters. Moot because r64674 made PendingScript copyable. > > WebCore/dom/PendingScript.h:69 > + virtual void notifyFinished(CachedResource*) > Please move to implementation file. It can't be inlined anyway. Done.
Tony Gentilcore
Comment 4 2010-08-04 17:13:52 PDT
Created attachment 63514 [details] Patch for landing
Tony Gentilcore
Comment 5 2010-08-06 10:16:17 PDT
Created attachment 63737 [details] Patch for landing
WebKit Commit Bot
Comment 6 2010-08-06 10:36:35 PDT
Comment on attachment 63737 [details] Patch for landing Clearing flags on attachment: 63737 Committed r64857: <http://trac.webkit.org/changeset/64857>
WebKit Commit Bot
Comment 7 2010-08-06 10:36:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.