Bug 43391

Summary:

Factor out PendingScript and protect its members

Product:

WebKit

Reporter:

Tony Gentilcore <tonyg>

Component:

New Bugs

Assignee:

Tony Gentilcore <tonyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

40934

Bug Blocks:

20710

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Description Tony Gentilcore 2010-08-02 16:27:57 PDT

Factor out PendingScript and protect its members

Comment 1 Tony Gentilcore 2010-08-02 16:32:58 PDT

Created attachment 63275 [details]
Patch

Comment 2 Adam Barth 2010-08-02 18:03:16 PDT

Comment on attachment 63275 [details]
Patch

WebCore/dom/PendingScript.h:44
 +  class PendingScript : public CachedResourceClient, Noncopyable {
Noncopyable should probably be the first base class, not that it really matters.

WebCore/dom/PendingScript.h:69
 +      virtual void notifyFinished(CachedResource*)
Please move to implementation file.  It can't be inlined anyway.

Comment 3 Tony Gentilcore 2010-08-04 17:10:56 PDT

(In reply to comment #2)
> (From update of attachment 63275 [details])
> WebCore/dom/PendingScript.h:44
>  +  class PendingScript : public CachedResourceClient, Noncopyable {
> Noncopyable should probably be the first base class, not that it really matters.

Moot because r64674 made PendingScript copyable.

> 
> WebCore/dom/PendingScript.h:69
>  +      virtual void notifyFinished(CachedResource*)
> Please move to implementation file.  It can't be inlined anyway.

Done.

Comment 4 Tony Gentilcore 2010-08-04 17:13:52 PDT

Created attachment 63514 [details]
Patch for landing

Comment 5 Tony Gentilcore 2010-08-06 10:16:17 PDT

Created attachment 63737 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2010-08-06 10:36:35 PDT

Comment on attachment 63737 [details]
Patch for landing

Clearing flags on attachment: 63737

Committed r64857: <http://trac.webkit.org/changeset/64857>

Comment 7 WebKit Commit Bot 2010-08-06 10:36:40 PDT

All reviewed patches have been landed.  Closing bug.