Summary: | Factor out PendingScript and protect its members | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | 40934 | ||||||||||
Bug Blocks: | 20710 | ||||||||||
Attachments: |
|
Description
Tony Gentilcore
2010-08-02 16:27:57 PDT
Created attachment 63275 [details]
Patch
Comment on attachment 63275 [details]
Patch
WebCore/dom/PendingScript.h:44
+ class PendingScript : public CachedResourceClient, Noncopyable {
Noncopyable should probably be the first base class, not that it really matters.
WebCore/dom/PendingScript.h:69
+ virtual void notifyFinished(CachedResource*)
Please move to implementation file. It can't be inlined anyway.
(In reply to comment #2) > (From update of attachment 63275 [details]) > WebCore/dom/PendingScript.h:44 > + class PendingScript : public CachedResourceClient, Noncopyable { > Noncopyable should probably be the first base class, not that it really matters. Moot because r64674 made PendingScript copyable. > > WebCore/dom/PendingScript.h:69 > + virtual void notifyFinished(CachedResource*) > Please move to implementation file. It can't be inlined anyway. Done. Created attachment 63514 [details]
Patch for landing
Created attachment 63737 [details]
Patch for landing
Comment on attachment 63737 [details] Patch for landing Clearing flags on attachment: 63737 Committed r64857: <http://trac.webkit.org/changeset/64857> All reviewed patches have been landed. Closing bug. |