Summary: | [wx] Crash during HitTest call | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Malcolm MacLeod <mmacleod> | ||||
Component: | WebKit wx | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kevino | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Malcolm MacLeod
2010-08-02 13:20:34 PDT
Created attachment 63249 [details]
Patch to fix initialisation crash
Comment on attachment 63249 [details] Patch to fix initialisation crash Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>? Please don't comment out code - just delete it if it's wrong. Thanks! Landed in r64568. A couple remarks for future patches. One, there is a 'patch' checkbox which lets the system know the attachment is a patch, and setting ? on the review queue marks it as needing review. (It also actually initiates try-bots which attempt to compile the patch.) Also, typically patches are supposed to contain a ChangeLog entry, which can be auto-generated using WebKitTools/Scripts/prepare-ChangeLog. Typically patches missing a ChangeLog entry are supposed to be given a bad review and sent back for reworking, but as this was fixing a crash, I felt it was best to be expedient and land this ASAP, adding the ChangeLog entry myself. (In reply to comment #3) > Thanks! Landed in r64568. > > A couple remarks for future patches. One, there is a 'patch' checkbox which lets the system know the attachment is a patch, and setting ? on the review queue marks it as needing review. (It also actually initiates try-bots which attempt to compile the patch.) > > Also, typically patches are supposed to contain a ChangeLog entry, which can be auto-generated using WebKitTools/Scripts/prepare-ChangeLog. Typically patches missing a ChangeLog entry are supposed to be given a bad review and sent back for reworking, but as this was fixing a crash, I felt it was best to be expedient and land this ASAP, adding the ChangeLog entry myself. Err, bad review is a poor choice of words. :) I mean an r-, which means it isn't ready to land. |