Bug 43359 – [Qt] Fix warnings: unknown conversion type character 'l' in format

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Csaba Osztrogonác]

Build QtWebKit on Windows with MinGW, there are some "warning: unknown conversion type character 'l' in format":

..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:404:36: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:404:36: warning: too many arguments for format

..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:413:36: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\wtf\text\WTFString.cpp:413:36: warning: too many arguments for format

..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many arguments for format

..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:76:84: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:76:84: warning: too many arguments for format

..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:79:44: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\platform\sql\SQLiteFileSystem.cpp:79:44: warning: too many arguments for format

We should use SCN... and PRI... macros from inttypes.h to avoid using %lli, %llu, ...

[Csaba Osztrogonác]

Created attachment 64122 [details]
proposed fix #1

Fix 4 warnings:

JavaScriptCore\wtf\text\WTFString.cpp:404:
return String::format("%lli", n);

JavaScriptCore\wtf\text\WTFString.cpp:413:
return String::format("%llu", n);

WebCore\platform\sql\SQLiteFileSystem.cpp:76:
fileName = pathByAppendingComponent(dbDir, String::format("%016llx.db", seq));

WebCore\platform\sql\SQLiteFileSystem.cpp:79:
return String::format("%016llx.db", seq);

[Csaba Osztrogonác]

Created attachment 64132 [details]
proposed fix #2

Fix this warning:
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many arguments for format

I prefer PRI and SCN macros defined in inttypes.h, but 
I can't find any occurance of them in WebKit trunk.
Accordingly I propose a fix similar to String::number(...).

JavaScriptCore/wtf/text/WTFString.cpp:
...
String String::number(long long n)
{
#if OS(WINDOWS) && !PLATFORM(QT)
    return String::format("%I64i", n);
#else
    return String::format("%lli", n);
#endif
}
...

[Csaba Osztrogonác]

Created attachment 64218 [details]
proposed fix #3

Fix 6 warnings (Windows - debug mode):

..\..\..\WebCore\platform\sql\SQLiteDatabase.cpp:159: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\platform\sql\SQLiteDatabase.cpp:159: warning: too many arguments for format

..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: format '%s' expects type 'char*', but argument 5 has type 'long long unsigned int'
..\..\..\WebCore\storage\DatabaseTracker.cpp:689: warning: too many arguments for format

..\..\..\WebCore\loader\icon\IconDatabase.cpp:1313: warning: unknown conversion type character 'z' in format
..\..\..\WebCore\loader\icon\IconDatabase.cpp:1313: warning: too many arguments for format

..\..\..\WebCore\loader\icon\IconDatabase.cpp:1637: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\loader\icon\IconDatabase.cpp:1637: warning: too many arguments for format

..\..\..\WebCore\loader\icon\IconDatabase.cpp:1641: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\loader\icon\IconDatabase.cpp:1641: warning: too many arguments for format

..\..\..\WebCore\platform\graphics\qt\MediaPlayerPrivatePhonon.cpp:537: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\platform\graphics\qt\MediaPlayerPrivatePhonon.cpp:537: warning: too many arguments for format

[Antonio Gomes]

Comment on attachment 64122 [details]
proposed fix #1


> @@ -1,3 +1,20 @@
> [phone]  Csaba Osztrogonác  <[e-mail]>

maybe you could fix you name spell :)

[Csaba Osztrogonác]

(In reply to comment #4)
> (From update of attachment 64122 [details])
> 
> > @@ -1,3 +1,20 @@
> > [phone]  Csaba Osztrogonác  <[e-mail]>
> 
> maybe you could fix you name spell :)

Bugzilla doesn't like me, but trac would be happy. ;)

[Csaba Osztrogonác]

Adam, could you review "proposed fix #2" and 
"proposed fix #3" Windows related patches, please?

[Csaba Osztrogonác]

Comment on attachment 64122 [details]
proposed fix #1

Clearing flags on attachment: 64122

Committed r65264: <http://trac.webkit.org/changeset/65264>

[WebKit Review Bot]

http://trac.webkit.org/changeset/65264 might have broken SnowLeopard Intel Release (Tests)

[Csaba Osztrogonác]

(In reply to comment #8)
> http://trac.webkit.org/changeset/65264 might have broken SnowLeopard Intel Release (Tests)

It must be a false positive alarm.

[Csaba Osztrogonác]

Comment on attachment 64132 [details]
proposed fix #2

Landed in http://trac.webkit.org/changeset/65426.

[Csaba Osztrogonác]

Comment on attachment 64218 [details]
proposed fix #3

Landed in http://trac.webkit.org/changeset/65427.

[Csaba Osztrogonác]

Reopen, because there are more 5 warnings in JavaScriptCore\interpreter\Interpreter.cpp revealed by enabling JSVALUE32_64 on Windows:

..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:426: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:426: warning: too many arguments for format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:438: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:438: warning: too many arguments for format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:447: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:447: warning: too many arguments for format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:470: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:470: warning: too many arguments for format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:485: warning: unknown conversion type character 'l' in format
..\..\..\JavaScriptCore\interpreter\Interpreter.cpp:485: warning: too many arguments for format

Fix is coming soon.