|Summary:||Compile fix for Android, add missing guards|
|Product:||WebKit||Reporter:||Kristian Monsen <kristianm>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, steveblock, yurys|
|Version:||528+ (Nightly build)|
Description Kristian Monsen 2010-08-02 06:41:52 PDT
INSPECTOR is not enabled on Android, some code was added to ScriptValue.cpp without guards.
Comment 1 Kristian Monsen 2010-08-02 06:45:06 PDT
Created attachment 63211 [details] Proposed patch.
Comment 2 Kristian Monsen 2010-08-02 06:51:31 PDT
Created attachment 63212 [details] Proposed patch (Updated Changelog description).
Comment 3 Steve Block 2010-08-02 07:06:12 PDT
Why is an equivalent fix not required for JSC. Also, it looks like you need to rebase and update your patch.
Comment 4 Kristian Monsen 2010-08-02 08:03:23 PDT
The JSC version is actually guarded in the same way.
Comment 5 Kristian Monsen 2010-08-02 08:16:24 PDT
Created attachment 63220 [details] Updated patch (rebase)
Comment 6 Steve Block 2010-08-02 08:45:03 PDT
Comment on attachment 63220 [details] Updated patch (rebase) r=me
Comment 7 WebKit Commit Bot 2010-08-02 09:05:28 PDT
Comment on attachment 63220 [details] Updated patch (rebase) Clearing flags on attachment: 63220 Committed r64464: <http://trac.webkit.org/changeset/64464>
Comment 8 WebKit Commit Bot 2010-08-02 09:05:32 PDT
All reviewed patches have been landed. Closing bug.