Bug 43335

Summary: Chromium DevTools: Get rid of APUAgent and DebuggerAgent
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: loislo, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
none
[PATCH] Proposed change with fixed style.
none
[PATCH] Profiler check added.
none
[PATCH] Proposed change with style addressed.
yurys: review+
[PATCH] Now I removed all agents + RPC itself.
none
[PATCH] Now I removed all agents + RPC itself (bot fixed). yurys: review+

Description Pavel Feldman 2010-08-02 05:06:03 PDT 
I'd like to remove DevToolsRPC infrastructure as a whole, starting with removing these two agents.
Comment 1 Pavel Feldman 2010-08-02 05:23:57 PDT 
Created attachment 63194 [details]
[PATCH] Proposed change.
Comment 2 WebKit Review Bot 2010-08-02 05:26:58 PDT 
Attachment 63194 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/DebuggerAgentImpl.h:55:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/src/WebDevToolsAgentImpl.cpp:515:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/public/WebDevToolsAgentClient.h:43:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 5 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2010-08-02 05:39:10 PDT 
Created attachment 63200 [details]
[PATCH] Proposed change with fixed style.
Comment 4 WebKit Review Bot 2010-08-02 05:43:14 PDT 
Attachment 63200 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebDevToolsAgentImpl.cpp:518:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/public/WebDevToolsAgentClient.h:43:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yury Semikhatsky 2010-08-02 05:45:12 PDT 
Comment on attachment 63200 [details]
[PATCH] Proposed change with fixed style.

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:297
 +          ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data);
looks like m_attached and m_profilerAgentImpl.get() checks are missing
Comment 6 Pavel Feldman 2010-08-02 05:47:43 PDT 
Created attachment 63203 [details]
[PATCH] Profiler check added.
Comment 7 WebKit Review Bot 2010-08-02 05:49:28 PDT 
Attachment 63203 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebDevToolsAgentImpl.cpp:296:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/public/WebDevToolsAgentClient.h:43:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 10 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Pavel Feldman 2010-08-02 05:53:32 PDT 
Created attachment 63205 [details]
[PATCH] Proposed change with style addressed.
Comment 9 WebKit Review Bot 2010-08-02 05:55:10 PDT 
Attachment 63205 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/public/WebDevToolsAgentClient.h:43:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Yury Semikhatsky 2010-08-02 05:56:17 PDT 
Comment on attachment 63205 [details]
[PATCH] Proposed change with style addressed.

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:302
 +      if (m_profilerAgentImpl.get() && ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data))
 if (m_profilerAgentImpl.get() && ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data)) should be

 if (m_profilerAgentImpl)
    ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data);
Comment 11 Pavel Feldman 2010-08-02 11:49:45 PDT 
Created attachment 63243 [details]
[PATCH] Now I removed all agents + RPC itself.

I'd like to land it as a two-sided change while I am on the duty tomorrow. Sorry about the size of the patch.
Comment 12 Eric Seidel (no email) 2010-08-02 12:51:24 PDT 
Attachment 63243 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3580746
Comment 13 Pavel Feldman 2010-08-02 13:27:58 PDT 
Created attachment 63248 [details]
[PATCH] Now I removed all agents + RPC itself (bot fixed).
Comment 14 Yury Semikhatsky 2010-08-03 00:31:27 PDT 
Comment on attachment 63248 [details]
[PATCH] Now I removed all agents + RPC itself (bot fixed).

WebCore/inspector/InspectorFrontend.h:156
 +          void didGetProfilerLogLines(int position, const String& data);
You should either put calling code behind the same guards or remove the guards here.Or remove these methods completely.
Comment 15 Pavel Feldman 2010-08-03 00:39:55 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebKit/chromium/public/WebDevToolsMessageData.h
	D	WebKit/chromium/public/WebDevToolsMessageTransport.h
	D	WebKit/chromium/src/APUAgentDelegate.h
	D	WebKit/chromium/src/DebuggerAgent.h
	D	WebKit/chromium/src/DevToolsRPC.h
	D	WebKit/chromium/src/DevToolsRPCJS.h
	D	WebKit/chromium/src/ProfilerAgent.h
	D	WebKit/chromium/src/ProfilerAgentImpl.cpp
	D	WebKit/chromium/src/ProfilerAgentImpl.h
	D	WebKit/chromium/src/ToolsAgent.h
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptProfiler.h
	M	WebCore/bindings/v8/ScriptProfiler.cpp
	M	WebCore/bindings/v8/ScriptProfiler.h
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/front-end/InspectorBackendStub.js
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/WebKit.gyp
	M	WebKit/chromium/public/WebDevToolsAgent.h
	M	WebKit/chromium/public/WebDevToolsAgentClient.h
	M	WebKit/chromium/public/WebDevToolsFrontend.h
	M	WebKit/chromium/public/WebDevToolsFrontendClient.h
	M	WebKit/chromium/src/DebuggerAgentImpl.cpp
	M	WebKit/chromium/src/DebuggerAgentImpl.h
	M	WebKit/chromium/src/DebuggerAgentManager.cpp
	M	WebKit/chromium/src/InspectorClientImpl.cpp
	M	WebKit/chromium/src/InspectorFrontendClientImpl.cpp
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
	M	WebKit/chromium/src/WebDevToolsAgentImpl.h
	M	WebKit/chromium/src/WebDevToolsFrontendImpl.cpp
	M	WebKit/chromium/src/WebDevToolsFrontendImpl.h
	M	WebKit/chromium/src/js/DevTools.js
	M	WebKit/chromium/src/js/DevToolsHostStub.js
	M	WebKit/chromium/src/js/ProfilerAgent.js
	M	WebKit/chromium/src/js/ProfilerProcessor.js
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.h
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsCallArgs.h
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp
	M	WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.h
Committed r64534