Bug 43315

Summary: Implement NPN_RemoveProperty
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-08-01 13:53:16 PDT
Implement NPN_RemoveProperty
Attachments
Patch (25.07 KB, patch)
2010-08-01 13:55 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-08-01 13:55:33 PDT
Created attachment 63171 [details] Patch
WebKit Review Bot
Comment 2 2010-08-01 14:00:05 PDT
Attachment 63171 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:63: PluginTest::NPN_GetStringIdentifier is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:68: PluginTest::NPN_GetIntIdentifier is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:78: PluginTest::NPN_RemoveProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:365: NPJSObject::NP_RemoveProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:39: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2010-08-01 14:27:15 PDT
http://trac.webkit.org/changeset/64444 might have broken SnowLeopard Intel Release (Tests)
Adam Barth
Comment 4 2010-08-10 22:53:50 PDT
This patch appears to have been landed.
Note You need to log in before you can comment on or make changes to this bug.