Bug 4331

Summary: dispatchEvent should raise an exception
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: DOMAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Throw exception
andersca: review-
Better solution darin: review+

Anders Carlsson
Reported 2005-08-08 01:05:19 PDT
If the event passed to dispatchEvent is null or unitialized, UNSPECIFIED_EVENT_TYPE_ERR should be raised.
Attachments
Throw exception (8.88 KB, patch)
2005-08-08 01:06 PDT, Anders Carlsson 		andersca: review-
DetailsFormatted DiffDiff
Better solution (19.80 KB, patch)
2005-08-08 14:02 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-08-08 01:06:11 PDT
Created attachment 3275 [details] Throw exception
Anders Carlsson
Comment 2 2005-08-08 02:10:48 PDT
Comment on attachment 3275 [details] Throw exception I think the check in dispatchEvent is wrong so I'll mark it review- for now.
Anders Carlsson
Comment 3 2005-08-08 14:02:33 PDT
Created attachment 3284 [details] Better solution
Darin Adler
Comment 4 2005-08-08 15:17:02 PDT
Comment on attachment 3284 [details] Better solution Instead of this: evt->type().isNull() || evt->type() =="" should use: evt->type().isEmpty() Otherwise, r=me.
Justin Garcia
Comment 5 2005-08-09 14:27:53 PDT
Landed this, with the change suggested by Darin
Lucas Forschler
Comment 6 2019-02-06 09:03:01 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.