Bug 43240

Summary: Add a check for WebViewClient being null.
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, hans, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39485    
Attachments:
Description Flags
Patch none

Satish Sampath
Reported 2010-07-30 05:23:10 PDT
It seems valid to pass in a null WebViewClient in the chromium port of WebKit, so check for that before invoking methods on it in the speech input code.
Attachments
Patch (1.55 KB, patch)
2010-07-30 05:25 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-07-30 05:25:53 PDT
Created attachment 63050 [details] Patch
Jeremy Orlow
Comment 2 2010-07-30 05:29:45 PDT
Comment on attachment 63050 [details] Patch r=me
Jeremy Orlow
Comment 3 2010-07-30 06:19:40 PDT
Comment on attachment 63050 [details] Patch Clearing flags on attachment: 63050 Committed r64352: <http://trac.webkit.org/changeset/64352>
Jeremy Orlow
Comment 4 2010-07-30 06:19:48 PDT
All reviewed patches have been landed. Closing bug.
Darin Fisher (:fishd, Google)
Comment 5 2010-07-30 09:51:10 PDT
FYI, it is more conventional to pass WebViewImpl* around within chromium/src/ than to pass WebViewClient*. You will frequently see code like this: if (viewImpl->client()) viewImpl->client()->someMethod()
Satish Sampath
Comment 6 2010-07-30 09:57:01 PDT
Thanks for the comment, I'll use that pattern going forward and change this the next time this code is touched.
Note You need to log in before you can comment on or make changes to this bug.