Bug 43240

Summary: Add a check for WebViewClient being null.
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: fishd, hans, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39485    
Description Flags
Patch none

Description Satish Sampath 2010-07-30 05:23:10 PDT
It seems valid to pass in a null WebViewClient in the chromium port of WebKit, so check for that before invoking methods on it in the speech input code.
Comment 1 Satish Sampath 2010-07-30 05:25:53 PDT
Created attachment 63050 [details]
Comment 2 Jeremy Orlow 2010-07-30 05:29:45 PDT
Comment on attachment 63050 [details]

Comment 3 Jeremy Orlow 2010-07-30 06:19:40 PDT
Comment on attachment 63050 [details]

Clearing flags on attachment: 63050

Committed r64352: <http://trac.webkit.org/changeset/64352>
Comment 4 Jeremy Orlow 2010-07-30 06:19:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Fisher (:fishd, Google) 2010-07-30 09:51:10 PDT
FYI, it is more conventional to pass WebViewImpl* around within chromium/src/ than to pass WebViewClient*.  You will frequently see code like this:

  if (viewImpl->client())
Comment 6 Satish Sampath 2010-07-30 09:57:01 PDT
Thanks for the comment, I'll use that pattern going forward and change this the next time this code is touched.