Summary: | REGRESSION: Memory leak within JSParser::JSParser | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | JavaScriptCore | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, ggaren, oliver | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.6 | ||||||
URL: | http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/DumpRenderTree7-leaks.txt | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2010-07-29 18:50:44 PDT
Is this a bug in ThreadSpecific? I think that this is a misuse of ThreadSpecific. It can't possibly destroy data for all threads in its own destructor. template<typename T> inline ThreadSpecific<T>::~ThreadSpecific() { pthread_key_delete(m_key); // Does not invoke destructor functions. } Created attachment 66301 [details]
proposed fix
Comment on attachment 66301 [details] proposed fix Clearing flags on attachment: 66301 Committed r66665: <http://trac.webkit.org/changeset/66665> All reviewed patches have been landed. Closing bug. |