Bug 4322

Summary: date-big-setdate.html testcase fails if the timezone isn't UTC-8
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: JavaScriptCoreAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Determine if the dates are sequential
darin: review-
Better test darin: review+

Anders Carlsson
Reported 2005-08-07 13:56:00 PDT
Since the date-big-setdate.html test case prints out the times, and since -expected.txt contains "UTC-8", it will fail if the timezone is different. Also, setDate sets different dates depending on the time zone. With UTC+1, setDate(120) sets the date to Thu Apr 30 1970 01:00:00 GMT+0100 With UTC-8, setDate(120) sets the date to Mon Mar 30 1970 16:00:00 GMT-0800 (Both Mozilla and Opera does the same thing, so this isn't a bug)
Attachments
Determine if the dates are sequential (3.62 KB, patch)
2005-08-07 14:01 PDT, Anders Carlsson 		darin: review-
DetailsFormatted DiffDiff
Better test (3.39 KB, patch)
2005-08-08 00:18 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-08-07 14:01:48 PDT
Created attachment 3268 [details] Determine if the dates are sequential This patch compares two following dates to see if they're sequential instead of printing out the dates.
Darin Adler
Comment 2 2005-08-07 18:00:54 PDT
Comment on attachment 3268 [details] Determine if the dates are sequential Looks to me like this has some && where it should have || in the success check. No? Also, should get rid of the unneeded "if (!validVars)".
Anders Carlsson
Comment 3 2005-08-08 00:18:28 PDT
Created attachment 3273 [details] Better test Turns out the test case was really broken. Here's a much simpler one that should work better
Justin Garcia
Comment 4 2005-08-09 14:45:32 PDT
Landing this
Note You need to log in before you can comment on or make changes to this bug.