Bug 43177

Summary: [WML] Include FormDataBuilder.h in WMLGoElement.h
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch none

Description Gyuyoung Kim 2010-07-29 00:48:52 PDT 
There are build breaks because of WMLGoElement.cpp as below,

/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp: In member function ‘void WebCore::WMLGoElement::preparePOSTRequest(WebCore::ResourceRequest&, bool, const WebCore::String&)’:
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:159: error: ‘FormDataBuilder’ has not been declared
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp: In member function ‘WTF::PassRefPtr<WebCore::FormData> WebCore::WMLGoElement::createFormData(const WTF::CString&)’:
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:192: error: ‘FormDataBuilder’ has not been declared
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:203: error: ‘FormDataBuilder’ has not been declared
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:204: error: ‘FormDataBuilder’ has not been declared
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:212: error: ‘FormDataBuilder’ has not been declared
/home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:216: error: ‘FormDataBuilder’ has not been declared
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLGoElement.cpp.o] error 1
make[1]: *** [WebCore/CMakeFiles/webcore_efl.dir/all] error 2

In order to fix these breaks, FormDataBuilder.h needs to be included in WMLGoElement.cpp.
Comment 1 Gyuyoung Kim 2010-07-29 00:52:23 PDT 
Created attachment 62926 [details]
patch
Comment 2 Eric Seidel (no email) 2010-08-06 13:06:44 PDT 
Comment on attachment 62926 [details]
patch

OK.
Comment 3 Eric Seidel (no email) 2010-08-07 20:13:41 PDT 
Comment on attachment 62926 [details]
patch

Clearing flags on attachment: 62926

Committed r64932: <http://trac.webkit.org/changeset/64932>
Comment 4 Eric Seidel (no email) 2010-08-07 20:13:46 PDT 
All reviewed patches have been landed.  Closing bug.