Summary: | [Qt] Factor LauncherWindow class out of main.cpp (QtTestBrowser) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kenneth, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 43199 | ||||||
Attachments: |
|
Description
Antonio Gomes
2010-07-28 21:19:36 PDT
Created attachment 62959 [details] (commit=r64291 , r=kenneth) patch v1 - add launcherwindow.cpp and h Attachment 62959 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/QtTestBrowser/launcherwindow.h:70: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/QtTestBrowser/launcherwindow.cpp:33: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/QtTestBrowser/main.cpp:33: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 62959 [details] (commit=r64291 , r=kenneth) patch v1 - add launcherwindow.cpp and h we probably want to handle the globals differently? Are you planning this? Comment on attachment 62959 [details] (commit=r64291 , r=kenneth) patch v1 - add launcherwindow.cpp and h Clearing flags on attachment: 62959 Committed r64291: <http://trac.webkit.org/changeset/64291> (In reply to comment #3) > (From update of attachment 62959 [details]) > we probably want to handle the globals differently? Are you planning this? Yes, in a follow up. |