| Summary: | Implement NPN_InvokeDefault and NPN_Construct | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2010-07-28 17:00:30 PDT
Created attachment 62894 [details]
Patch
Attachment 62894 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:551: NPN_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:635: NPN_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:270: NPJSObject::NP_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:291: NPJSObject::NP_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:80: NP_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 5 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 62894 [details]
Patch
More * issues :(.
Otherwise, r=me.
Committed r64246: <http://trac.webkit.org/changeset/64246> |