Bug 4313

Summary: eliminate KJS::Value and KJS::Object smart pointer wrappers (for simplicity and speed)
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to remove the wrappers as of today
none
patch, revised to work after Maciej's PropertySlot change mjs: review+

Darin Adler
Reported 2005-08-06 21:31:07 PDT
Now that we don't get any benefit from the smartness of the KJS::Value and KJS::Object smart pointer classes, we should remove them. This will make the API better since it will remove the ambiguity about when to use ValueImp and when to use Value, and it will also should make things a little faster.
Attachments
patch to remove the wrappers as of today (928.34 KB, patch)
2005-08-06 22:02 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch, revised to work after Maciej's PropertySlot change (931.19 KB, patch)
2005-08-07 18:23 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-08-06 22:02:52 PDT
Created attachment 3251 [details] patch to remove the wrappers as of today Here's the patch as of this moment. I know I'll have to redo a lot of it once Maciej lands what he's currently working on.
Darin Adler
Comment 2 2005-08-07 18:23:20 PDT
Created attachment 3270 [details] patch, revised to work after Maciej's PropertySlot change
Darin Adler
Comment 3 2005-08-07 20:18:09 PDT
My performance measurement today shows a 2% speedup in iBench JavaScript with this change. Earlier tests did not show a speed-up, so this is welcome news. Hooray!
Maciej Stachowiak
Comment 4 2005-08-07 20:59:50 PDT
Comment on attachment 3270 [details] patch, revised to work after Maciej's PropertySlot change rs=me
David Kilzer (:ddkilzer)
Comment 5 2006-03-15 07:12:36 PST
NOTE: This bug also fixed Bug 4059.
Note You need to log in before you can comment on or make changes to this bug.