Bug 4310

Summary: "sheet" method is unimplemented in Obj-C DOM API
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit APIAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to implement the method eric: review+

Description Darin Adler 2005-08-06 20:19:16 PDT
There's a sheet method declared but not implemented in the Objective-C DOM wrappers.
Comment 1 Darin Adler 2005-08-06 20:20:08 PDT
Created attachment 3247 [details]
patch to implement the method
Comment 2 John Sullivan 2005-08-08 09:25:24 PDT
Comment on attachment 3247 [details]
patch to implement the method

Patch looks good, but needs some sort of testing. r=me if you find a way to
test it.
Comment 3 Eric Seidel (no email) 2005-09-17 14:57:48 PDT
Comment on attachment 3247 [details]
patch to implement the method

Looks great.  (this code actually benifits from the odd behavior of the last
patch, in that it will "correctly" return a DOMCSSStyleSheet or DOMStyleSheet
depending on the impl.)

r=me
Comment 4 Eric Seidel (no email) 2005-09-18 14:44:45 PDT
As ggaren correctly points out, all of these really should have layout tests.  For better or worse I ignored 
that fact, realizing that we don't currently (AFAIK) have any way of testing the Obj-C DOM API.  I talked 
with andersca a bit on IRC, he said he started the py-objc Obj-C DOM testing system, but hasn't finished 
yet.
Comment 5 Darin Adler 2005-09-23 11:20:16 PDT
Note that the "odd behavior" that Eric mentions here is the design of the DOM wrappers. The class of the 
Objective-C DOM wrapper mirrors the class of the actual DOM object it's wrapping. That way you can use 
standard Objective-C techniques like "isKindOfClass:" and downcasting on the wrappers.