Bug 43096 – [chromium] linux chromium sends double clicks too often

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Evan Stade]

see http://code.google.com/p/chromium/issues/detail?id=50380

[Evan Stade]

Created attachment 62782 [details]
patch

[WebKit Review Bot]

Attachment 62782 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:55:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:37:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:113:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

Comment on attachment 62782 [details]
patch

Please fix the style errors.  Otherwise, LGTM.

WebKit/chromium/src/gtk/WebInputEventFactory.cpp:48
 +  bool allowDoubleClick(gint timeDiff, gint xDiff, gint yDiff)
Nit: Maybe call it isDoubleClick or countAsDoubleClick?

[Evan Stade]

Created attachment 62792 [details]
try2

nits fixed, but I think some of the header nits are not applicable for test files (since there is no equivalent .h for a given .cpp)

[WebKit Review Bot]

Attachment 62792 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

LGTM, but I'm not a reviewer

[WebKit Commit Bot]

Comment on attachment 62792 [details]
try2

Rejecting patch 62792 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 62792, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=62792&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=43096&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 62792 from bug 43096.
ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Evan Martin]

You need to leave in the "unreviewed (OOPS)" part of the changelog for the commit tools to accept it.  :(

[Adam Barth]

Created attachment 64072 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 64072 [details]
Patch for landing

Clearing flags on attachment: 64072

Committed r65152: <http://trac.webkit.org/changeset/65152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.