Summary: | History.pushState() + navigation operates on top frame when called from nested context | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Schuh <jschuh> | ||||||||
Component: | History | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, beidson, eric, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Justin Schuh
2010-07-27 14:48:38 PDT
Created attachment 62773 [details]
simple fix (wip)
Here's the fix. I still need to add a layout test, etc. I'm also thinking of
changing createItemTree to return the target item as an out param so that we
can avoid the recursive walk done by HistoryItem::targetItem().
Created attachment 62795 [details]
v1 patch
Landed as http://trac.webkit.org/changeset/64369 http://trac.webkit.org/changeset/64369 might have broken Qt Linux Release |