Bug 43067

Summary: fast/dom/prototype-inheritance.html fails from r64141
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, jorlow, victorw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch jorlow: review+

Victor Wang
Reported 2010-07-27 12:06:03 PDT
This layout test fails on chromium webkit canary bot: fast/dom/prototype-inheritance.html Looks like http://trac.webkit.org/changeset/64141 causes this failure.
Attachments
Patch (2.55 KB, patch)
2010-07-28 07:18 PDT, Andrei Popescu 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2010-07-27 15:39:40 PDT
Hmm, are you sure that's what's causing it? Seems unlikely. Anyway, I will look tomorrow (I am in London and it's midnight right now). If you are certain that my change is the cause, please roll it out and I will fix it tomorrow.
Victor Wang
Comment 2 2010-07-27 15:56:46 PDT
(In reply to comment #1) > Hmm, are you sure that's what's causing it? Seems unlikely. Anyway, I will look tomorrow (I am in London and it's midnight right now). If you are certain that my change is the cause, please roll it out and I will fix it tomorrow. Looks to me this is the cause. I did not manually run it to verify so not 100% sure. Here are the actual test results: ---- Make sure prototypes are set up using the window a property came from, instead of the lexical global object. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS inner.Array.isInner is true ... FAIL inner.IDBKeyRange.isInner should be true. Was false. FAIL inner.IDBKeyRange.constructor.isInner should be true. Was false. PASS inner.Image.isInner is true ... FAIL inner.Infinity.isInner should be true. Was false. FAIL inner.Infinity.constructor.isInner should be true. Was false. PASS inner.JSON.isInner is true
Jeremy Orlow
Comment 3 2010-07-28 03:29:43 PDT
Andrei, I'm guessing this failure is why all this stuff is hand-written right now. There must be some subtle differences in semantics that matter. And/or you need to add it to the list of stuff it doesn't check. ....actually I think it's the latter. :-)
Andrei Popescu
Comment 4 2010-07-28 07:18:32 PDT
Created attachment 62818 [details] Patch
Jeremy Orlow
Comment 5 2010-07-28 08:41:21 PDT
Comment on attachment 62818 [details] Patch LayoutTests/ChangeLog:11 + Reviewed by NOBODY (OOPS!). This should go first. r=me
Andrei Popescu
Comment 6 2010-07-28 09:37:09 PDT
Committed r64210: <http://trac.webkit.org/changeset/64210> Please mark the bug as fixed if you are satisfied.
Note You need to log in before you can comment on or make changes to this bug.