Summary: | Provide a Helpful Link for Web Inspector Bugs in Bugzilla | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, ddkilzer, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2010-07-27 11:54:48 PDT
Created attachment 62718 [details]
[PATCH] Add a fake "Inspector" component, which uses the link
Created attachment 62719 [details]
[IMAGE] What it should look like
Comment on attachment 62718 [details] [PATCH] Add a fake "Inspector" component, which uses the link > diff --git a/BugsSite/template/en/default/global/choose-product.html.tmpl b/BugsSite/template/en/default/global/choose-product.html.tmpl This looks great, except you need to copy template/en/default/global/choose-product.html.tmplm to template/en/custom/global/choose-product.html.tmpl and then modify that. r- to copy and modify a custom copy of the template file. Created attachment 62722 [details]
[PATCH] New template in the custom directory.
I would have thought git would have determined it was a copy. Apparently it didn't. =/ Comment on attachment 62722 [details]
[PATCH] New template in the custom directory.
r=me
Comment on attachment 62722 [details]
[PATCH] New template in the custom directory.
Rejecting patch 62722 from commit-queue.
Unexpected failure when processing patch! Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 62722, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 64, in _run
step(tool, options).run(state)
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 66, in run
if self._has_valid_reviewer(changelog_entry):
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 48, in _has_valid_reviewer
if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'
Comment on attachment 62722 [details]
[PATCH] New template in the custom directory.
Rejecting patch 62722 from commit-queue.
Unexpected failure when processing patch! Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 62722, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 64, in _run
step(tool, options).run(state)
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 66, in run
if self._has_valid_reviewer(changelog_entry):
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 48, in _has_valid_reviewer
if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'
Thanks for the idea and review Dave! Its working on https://bugs.webkit.org/enter_bug.cgi Landed Manually. Committing to http://svn.webkit.org/repository/webkit/trunk ... M BugsSite/ChangeLog A BugsSite/template/en/custom/global/choose-product.html.tmpl Committed r64168 = 1b66af104c145b0c752bd5aac6ebffe8f44387bd (refs/remotes/trunk) http://trac.webkit.org/changeset/64168 |