Summary: | cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Berend-Jan Wever <skylined> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, eric, lcamtuf | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows Vista | ||||||||
URL: | http://code.google.com/p/chromium/issues/detail?id=50352 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 42959 | ||||||||
Attachments: |
|
Description
Berend-Jan Wever
2010-07-27 04:26:54 PDT
frame()->selection() can't be null. It's a component object of the frame. The frame itself must be null. Created attachment 63831 [details]
Patch
Comment on attachment 63831 [details]
Patch
LGTM.
Comment on attachment 63831 [details] Patch Clearing flags on attachment: 63831 Committed r64947: <http://trac.webkit.org/changeset/64947> All reviewed patches have been landed. Closing bug. Is there a reason why this didn't have a regression test? > Is there a reason why this didn't have a regression test?
I'm not really sure how to call the API. If we have infinite null checks on Frame* that don't have tests. The code is wrong on its face.
|