| Summary: | [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, kling | ||||||||||
| Priority: | P2 | Keywords: | Performance, Qt | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Noam Rosenthal
2010-07-26 15:22:58 PDT
Created attachment 62623 [details]
Patch
Comment on attachment 62623 [details] Patch Rejecting patch 62623 from commit-queue. noam.rosenthal@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 62623 [details] Patch Rejecting patch 62623 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Hunk #2 succeeded at 3787 (offset 1415 lines). patching file WebKitTools/QtTestBrowser/main.cpp Hunk #1 FAILED at 287. Hunk #2 FAILED at 1116. Hunk #3 FAILED at 1132. Hunk #4 succeeded at 163 with fuzz 1 (offset -996 lines). 3 out of 4 hunks FAILED -- saving rejects to file WebKitTools/QtTestBrowser/main.cpp.rej Full output: http://queues.webkit.org/results/3568843 Created attachment 63485 [details]
Patch
Comment on attachment 63485 [details] Patch Rejecting patch 63485 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: diffs from patch file(s). patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Hunk #2 succeeded at 4109 (offset 254 lines). patching file WebKitTools/QtTestBrowser/launcherwindow.cpp Hunk #1 succeeded at 366 with fuzz 2 (offset -41 lines). patching file WebKitTools/QtTestBrowser/main.cpp Hunk #1 FAILED at 116. Hunk #2 FAILED at 136. Hunk #3 succeeded at 160 with fuzz 1 (offset 2 lines). 2 out of 3 hunks FAILED -- saving rejects to file WebKitTools/QtTestBrowser/main.cpp.rej Full output: http://queues.webkit.org/results/3630488 Created attachment 63730 [details]
Patch
This QtTestBrowser thing is a moving target... hopefully no merge conflicts this time
Created attachment 63731 [details]
Patch
This QtTestBrowser thing is a moving target... hopefully no merge conflicts this time
Comment on attachment 63485 [details] Patch Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 63485 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 63731 [details]
Patch
LGTM. re=me
Committed r65792: <http://trac.webkit.org/changeset/65792> |