Bug 43010 – [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Noam Rosenthal]

This is needed to test GL-based AC rapidly.

[Noam Rosenthal]

Created attachment 62623 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 62623 [details]
Patch

Rejecting patch 62623 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 62623 [details]
Patch

Rejecting patch 62623 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
Hunk #2 succeeded at 3787 (offset 1415 lines).
patching file WebKitTools/QtTestBrowser/main.cpp
Hunk #1 FAILED at 287.
Hunk #2 FAILED at 1116.
Hunk #3 FAILED at 1132.
Hunk #4 succeeded at 163 with fuzz 1 (offset -996 lines).
3 out of 4 hunks FAILED -- saving rejects to file WebKitTools/QtTestBrowser/main.cpp.rej

Full output: http://queues.webkit.org/results/3568843

[Noam Rosenthal]

Created attachment 63485 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 63485 [details]
Patch

Rejecting patch 63485 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Last 500 characters of output:
 diffs from patch file(s).
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
Hunk #2 succeeded at 4109 (offset 254 lines).
patching file WebKitTools/QtTestBrowser/launcherwindow.cpp
Hunk #1 succeeded at 366 with fuzz 2 (offset -41 lines).
patching file WebKitTools/QtTestBrowser/main.cpp
Hunk #1 FAILED at 116.
Hunk #2 FAILED at 136.
Hunk #3 succeeded at 160 with fuzz 1 (offset 2 lines).
2 out of 3 hunks FAILED -- saving rejects to file WebKitTools/QtTestBrowser/main.cpp.rej

Full output: http://queues.webkit.org/results/3630488

[Noam Rosenthal]

Created attachment 63730 [details]
Patch

This QtTestBrowser thing is a moving target... hopefully no merge conflicts this time

[Noam Rosenthal]

Created attachment 63731 [details]
Patch

This QtTestBrowser thing is a moving target... hopefully no merge conflicts this time

[Eric Seidel (no email)]

Comment on attachment 63485 [details]
Patch

Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 63485 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Ariya Hidayat]

Comment on attachment 63731 [details]
Patch

LGTM. re=me

[Andreas Kling]

Committed r65792: <http://trac.webkit.org/changeset/65792>