Summary: | Simplify speech input plumbing in webcore and webkit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Satish Sampath <satish> | ||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 39485 | ||||||||
Attachments: |
|
Description
Satish Sampath
2010-07-26 15:01:15 PDT
Created attachment 62618 [details]
Patch
Comment on attachment 62618 [details] Patch The code change looks OK. But please re-make the patch with the latest WebKit. Our commit-queue has a bug for ChangeLog diff not starting with the first line like your patch. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index e26d1854a9a330a50728633b8e55d07feb945f6d..7226ef6e566e8a6849f4f2cc3ccd614f118f3963 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,5 +1,39 @@ > 2010-07-26 Satish Sampath <satish@chromium.org> > > + Reviewed by NOBODY (OOPS!). > + > + Simplify speech input plumbing in webcore and webkit > + https://bugs.webkit.org/show_bug.cgi?id=43008 > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > index 0309952965ca68664268ba361e5c63f80f6c7612..3dddb2d6bc562091b15d992050558259a1c7d6dd 100644 > --- a/WebKit/chromium/ChangeLog > +++ b/WebKit/chromium/ChangeLog > @@ -1,5 +1,20 @@ > 2010-07-26 Satish Sampath <satish@chromium.org> > > + Reviewed by NOBODY (OOPS!). > + > + Simplify speech input plumbing in webcore and webkit > + https://bugs.webkit.org/show_bug.cgi?id=43008 Created attachment 62646 [details]
Patch
Merged with latest.
Comment on attachment 62646 [details]
Patch
OK
Comment on attachment 62646 [details] Patch Clearing flags on attachment: 62646 Committed r64111: <http://trac.webkit.org/changeset/64111> All reviewed patches have been landed. Closing bug. |