Bug 42993 – REGRESSION (r63994): Bank of America's home page is horribly mis-rendered

• Component: Tables
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

After <http://trac.webkit.org/changeset/63994> Bank of America’s home page is rendered incorrectly.  That change is associated with bug 40775.

<rdar://problem/8235236>

[Kevin M. Dean]

I also see a likely related issue with the table layouts on some forums site's like:

http://board.jdownloader.org/forumdisplay.php?f=13

On first load, the tables don't render right. Reload the page and it looks correct. Started between r63958-r64033.

[Fady Samuel]

I have a patch underway. It'll be ready for review in a few minutes, just waiting on a try bot to confirm I didn't break anything new.

[Fady Samuel]

Created attachment 62696 [details]
Fixed table rendering on partial layout during load

[James Robinson]

Where are the regression tests for this fix?

[Fady Samuel]

(In reply to comment #4)
> Where are the regression tests for this fix?

slashdot logo test was flaky. Now it's not. I suppose I can change it to force an early layout.

[Fady Samuel]

(In reply to comment #5)
> (In reply to comment #4)
> > Where are the regression tests for this fix?
> 
> slashdot logo test was flaky. Now it's not. I suppose I can change it to force an early layout.

A bunch of bugs were filed related to the flaky table rendering. This patch should address them all in one fell swoop.

[Fady Samuel]

Created attachment 62712 [details]
Fixed table rendering on partial layout during load

slashdot test forces early layout.

[Mark Rowe (bdash)]

Comment on attachment 62712 [details]
Fixed table rendering on partial layout during load

> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> index 2f8c734..25f2b39 100644
> --- a/LayoutTests/ChangeLog
> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,15 @@
> [phone]  [e-mail]  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Restored the expectation for the slashdot logo table test.
> +
> +        REGRESSION (r63994): Bank of America's home page is horribly mis-rendered
> +        https://bugs.webkit.org/show_bug.cgi?id=42993

Please put bug titles at the top of the ChangeLog entry rather than at the bottom.  Not only does this match every single other ChangeLog entry ever written, it makes them much easier to find when visually scanning the ChangeLog.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index e26d185..87f7378 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,35 @@
> [phone]  [e-mail]  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fixed bug introduced by patch for bug 40775. 
> +
> +        The new table rendering code did not take into account table layouts starting
> +        during a partial construction of the table render tree. As such,
> +        multiple layouts on the same table resulted in more columns being generated.
> +        This patch solves this issue.
> +
> +        REGRESSION (r63994): Bank of America's home page is horribly mis-rendered
> +        https://bugs.webkit.org/show_bug.cgi?id=42993

Ditto.

[James Robinson]

Don't change an existing test, please add a new test that fails without your patch and passes with it.  I believe tables/mozilla/ is imported from another source.

[Fady Samuel]

Created attachment 62724 [details]
Fixed table rendering on partial layout during load

Added a new simple layout test that checks for this bug.

[Fady Samuel]

Created attachment 62728 [details]
Fixed table rendering on partial layout during load

[Fady Samuel]

Created attachment 62733 [details]
Fixed Table Rendering On Partial Layout

Hi! First bug report for WebKit. Seems like I have the same problem. r63958 works fine. Using r64033 and later, BoA site, and like Geocaching.com for me, all render the layout strangely & very reproductively. I use PPC G5 Mac OS X 10.5.8. Thanks for improving WebKit, and Safari too!

Hi! First bug report for WebKit. Seems like I have the same problem. r63958 works fine. Using r64033 and later, BoA site, and like Geocaching.com for me, all render the layout strangely & very reproductively. I use PPC G5 Mac OS X 10.5.8. Thanks for improving WebKit, and Safari too!

[Fady Samuel]

(In reply to comment #14)
> Hi! First bug report for WebKit. Seems like I have the same problem. r63958 works fine. Using r64033 and later, BoA site, and like Geocaching.com for me, all render the layout strangely & very reproductively. I use PPC G5 Mac OS X 10.5.8. Thanks for improving WebKit, and Safari too!

The patch that fixes the problem is above. Just pending review.

[Dave Hyatt]

Comment on attachment 62733 [details]
Fixed Table Rendering On Partial Layout

r=me

Still not fixed in WebKit-SVN-r64156 under Safari 5.0.0.
Going to update to Safari 5.0.1 now, and see the improvements.
Still waiting approval for this fix, I guess.

[James Robinson]

Comment on attachment 62733 [details]
Fixed Table Rendering On Partial Layout

Clearing flags on attachment: 62733

Committed r64225: <http://trac.webkit.org/changeset/64225>

[James Robinson]

All reviewed patches have been landed.  Closing bug.

All seems to be fixed in WebKit-SVN-r64246. Awesome!
Thanks for the quick response!