Bug 42986

Summary: Add prompt and confirm client functions to WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-07-26 11:50:47 PDT
Add prompt and confirm client functions to WebKit2
Attachments
Patch (14.99 KB, patch)
2010-07-26 11:52 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-26 11:52:28 PDT
Created attachment 62591 [details] Patch
Anders Carlsson
Comment 2 2010-07-26 11:55:08 PDT
Comment on attachment 62591 [details] Patch rà
WebKit Review Bot
Comment 3 2010-07-26 11:58:03 PDT
Attachment 62591 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:129: Extra space between WKPageRunJavaScriptConfirmCallback and runJavaScriptConfirm [whitespace/declaration] [3] WebKit2/UIProcess/API/C/WKPage.h:130: Extra space between WKPageRunJavaScriptPromptCallback and runJavaScriptPrompt [whitespace/declaration] [3] WebKit2/UIProcess/WebUIClient.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2010-07-26 12:57:50 PDT
Fixed in http://trac.webkit.org/changeset/64065.
Note You need to log in before you can comment on or make changes to this bug.