Summary: | Add prompt and confirm client functions to WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-07-26 11:50:47 PDT
Created attachment 62591 [details]
Patch
Comment on attachment 62591 [details]
Patch
rĂ
Attachment 62591 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:129: Extra space between WKPageRunJavaScriptConfirmCallback and runJavaScriptConfirm [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:130: Extra space between WKPageRunJavaScriptPromptCallback and runJavaScriptPrompt [whitespace/declaration] [3]
WebKit2/UIProcess/WebUIClient.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Fixed in http://trac.webkit.org/changeset/64065. |