Bug 42974

Summary: [Qt] WebKit::PageClient implementation needs a dedicated class
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, kenneth, koivisto, tonikitoo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Balazs Kelemen
Reported 2010-07-26 08:04:48 PDT
WebPageProxy is the owner of the PageClient so setting the QWKPagePrivate as PageClient is wrong (QWKPagePrivate holds the WebPageProxy and that would destroy it so the callchain ends in double destruction).
Attachments
proposed patch (3.69 KB, patch)
2010-07-26 08:10 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch (3.69 KB, patch)
2010-07-26 08:32 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch (3.94 KB, patch)
2010-07-27 04:44 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-07-26 08:10:26 PDT
Created attachment 62574 [details] proposed patch
Balazs Kelemen
Comment 2 2010-07-26 08:32:28 PDT
Created attachment 62577 [details] proposed patch Oops, the last one did not build.
Kenneth Rohde Christiansen
Comment 3 2010-07-26 10:09:34 PDT
Comment on attachment 62577 [details] proposed patch page->setPageClient(new PageClientImpl(qq)); If this is being deleted automatically (is it an OwnPtr?), it would be nice with a comment here.
Balazs Kelemen
Comment 4 2010-07-27 04:44:30 PDT
Created attachment 62682 [details] proposed patch Comment - suggested by Kenneth - has been added.
WebKit Commit Bot
Comment 5 2010-07-27 05:27:40 PDT
Comment on attachment 62682 [details] proposed patch Clearing flags on attachment: 62682 Committed r64122: <http://trac.webkit.org/changeset/64122>
WebKit Commit Bot
Comment 6 2010-07-27 05:27:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.