|Summary:||[Qt] WebKit::PageClient implementation needs a dedicated class|
|Product:||WebKit||Reporter:||Balazs Kelemen <kbalazs>|
|Component:||WebKit2||Assignee:||Balazs Kelemen <kbalazs>|
|Severity:||Normal||CC:||abecsi, commit-queue, kenneth, koivisto, tonikitoo|
|Version:||528+ (Nightly build)|
Description Balazs Kelemen 2010-07-26 08:04:48 PDT
WebPageProxy is the owner of the PageClient so setting the QWKPagePrivate as PageClient is wrong (QWKPagePrivate holds the WebPageProxy and that would destroy it so the callchain ends in double destruction).
Comment 2 Balazs Kelemen 2010-07-26 08:32:28 PDT
Created attachment 62577 [details] proposed patch Oops, the last one did not build.
Comment 3 Kenneth Rohde Christiansen 2010-07-26 10:09:34 PDT
Comment on attachment 62577 [details] proposed patch page->setPageClient(new PageClientImpl(qq)); If this is being deleted automatically (is it an OwnPtr?), it would be nice with a comment here.
Comment 4 Balazs Kelemen 2010-07-27 04:44:30 PDT
Created attachment 62682 [details] proposed patch Comment - suggested by Kenneth - has been added.
Comment 5 WebKit Commit Bot 2010-07-27 05:27:40 PDT
Comment on attachment 62682 [details] proposed patch Clearing flags on attachment: 62682 Committed r64122: <http://trac.webkit.org/changeset/64122>
Comment 6 WebKit Commit Bot 2010-07-27 05:27:44 PDT
All reviewed patches have been landed. Closing bug.