Summary: | [Qt] WebKit::PageClient implementation needs a dedicated class | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
Component: | WebKit2 | Assignee: | Balazs Kelemen <kbalazs> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abecsi, commit-queue, kenneth, koivisto, tonikitoo | ||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Balazs Kelemen
2010-07-26 08:04:48 PDT
Created attachment 62574 [details]
proposed patch
Created attachment 62577 [details]
proposed patch
Oops, the last one did not build.
Comment on attachment 62577 [details]
proposed patch
page->setPageClient(new PageClientImpl(qq));
If this is being deleted automatically (is it an OwnPtr?), it would be nice with a comment here.
Created attachment 62682 [details]
proposed patch
Comment - suggested by Kenneth - has been added.
Comment on attachment 62682 [details] proposed patch Clearing flags on attachment: 62682 Committed r64122: <http://trac.webkit.org/changeset/64122> All reviewed patches have been landed. Closing bug. |