Bug 42967

Summary:

[IndexedDB] IndexedDatabase should be called IDBFactory.

Product:

WebKit

Reporter:

Andrei Popescu <andreip>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, bulach, dglazkov, eric, jorlow, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.w3.org/Bugs/Public/show_bug.cgi?id=9790

Bug Depends on:

Bug Blocks:

42966, 42969

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	jorlow: review+

Andrei Popescu

Reported 2010-07-26 05:07:01 PDT

Following from: http://www.w3.org/Bugs/Public/show_bug.cgi?id=9790 the IndexedDatabase should be called IDBFactory. It should also have a method called "databases" that returns a list of all database names.

Attachments
Patch (86.32 KB, patch) 2010-07-26 14:36 PDT, Andrei Popescu	no flags	Details Formatted Diff Diff
Patch (74.94 KB, patch) 2010-07-29 08:10 PDT, Andrei Popescu	no flags	Details Formatted Diff Diff
Patch (73.73 KB, patch) 2010-07-29 08:29 PDT, Andrei Popescu	no flags	Details Formatted Diff Diff
Patch (73.73 KB, patch) 2010-07-29 09:13 PDT, Andrei Popescu	jorlow: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrei Popescu

Comment 1 2010-07-26 14:36:27 PDT

Created attachment 62606 [details] Patch

Jeremy Orlow

Comment 2 2010-07-27 04:26:45 PDT

Comment on attachment 62606 [details] Patch LayoutTests/storage/indexeddb/idb-factory.html:11 + <script src="script-tests/idb-factory.js"></script> You need to sync. This is no longer here. WebCore/storage/IDBFactoryPrivateImpl.cpp:55 + PassRefPtr<DOMStringList> IDBFactoryPrivateImpl::databases() const I really don't think we should mix new functionality with the renaming patches. We need to discuss the naming of this stuff...

Jeremy Orlow

Comment 3 2010-07-27 04:40:43 PDT

Talked in person. Andrei is going to split this up and better document the new naming scheme.

Andrei Popescu

Comment 4 2010-07-29 08:10:12 PDT

Created attachment 62947 [details] Patch

Andrei Popescu

Comment 5 2010-07-29 08:29:43 PDT

Created attachment 62948 [details] Patch

WebKit Review Bot

Comment 6 2010-07-29 09:11:34 PDT

Attachment 62947 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3619299