Summary: | REGRESSION (r60104): Zoom level is unexpectedly reset on page reload | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xiaomei Ji <xji> | ||||||
Component: | Page Loading | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, bdakin, beidson, darin, dbates, dev+webkit, dglazkov, eric, fishd, mihaip, sullivan, webkit.review.bot | ||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.6 | ||||||||
URL: | http://www.apple.com/startpage | ||||||||
Bug Depends on: | 46093 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Xiaomei Ji
2010-07-22 17:45:44 PDT
In shipping Safari/WebKit 5.0, the page stays zoomed in. *** Bug 41573 has been marked as a duplicate of this bug. *** This regressed in http://trac.webkit.org/changeset/60104 I’m surprised that moving these functions caused this. I guess a new FrameView is created and does not inherit the zoom level from the older FrameView? Created attachment 67963 [details]
Patch
We should be able to test this change by using a render tree dump/pixel test and eventSender.zoomPageIn(). Created attachment 67977 [details]
Layout Test
I was not sure where to place this test case. I noticed other test cases that used eventSender.zoomInPage() in fast/css. So, I put the test case in this directory. I am open to suggestions.
(In reply to comment #8) > Created an attachment (id=67977) [details] > Layout Test > > I was not sure where to place this test case. I noticed other test cases that used eventSender.zoomInPage() in fast/css. So, I put the test case in this directory. I am open to suggestions. I mean't to write eventSender.zoomPageIn() instead of eventSender.zoomInPage(). Comment on attachment 67977 [details]
Layout Test
I’m surprised this works, but it’s good news that it does.
Committed r67762: <http://trac.webkit.org/changeset/67762> http://trac.webkit.org/changeset/67762 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release (In reply to comment #12) > http://trac.webkit.org/changeset/67762 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release All Chromium builds are borked :( This appears to have torched the tree. :( I've put up a patch at bug 46040 that should at least fix the Snow Leopard bot (and unblock the commit queue) if someone wouldn't mind r+-ing and landing it for me. Sorry about the incorrect logic and build breakage. Hope everything’s fixed now. Thanks to those who helped patch things up. |