Bug 42825
| Summary: | WebKitTestRunner never destroys its main PlatformWebView (and thus its WKView[Ref]) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | andersca, sam |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Roben (:aroben)
WebKitTestRunner allocates a main PlatformWebView on the heap and never destroys it. It should clean up after itself!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
See also bug 42828, which is triggered by this bug.
Adam Roben (:aroben)
It's possible that this is a cause of bug 42785. See discussion in that bug for more details.
Adam Roben (:aroben)
<rdar://problem/8222252>
Adam Roben (:aroben)
I added some code to the end of TestController::run that deletes m_mainWebView. This causes a crash in the web process on Mac. It crashes in CoreIPC::Connection::dispatchConnectionDidClose because m_client is null. dispatchConnectionDidClose must be getting called twice.
Adam Roben (:aroben)
(In reply to comment #4)
> I added some code to the end of TestController::run that deletes m_mainWebView. This causes a crash in the web process on Mac. It crashes in CoreIPC::Connection::dispatchConnectionDidClose because m_client is null. dispatchConnectionDidClose must be getting called twice.
Anders fixed this crash in r63916.
Adam Roben (:aroben)
This was fixed in r64485.