Bug 4280 – Would be nice if webkitdirs.pm could check system/xcode version

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

It would be nice if webkitdirs.pm could check system/xcode version.

For example, a dev complained tonight that xcode wasn't building, with this log:

localhost:~ user$  WebKitTools/Scripts/build-webkit
xcodebuild: Error: the project name JavaScriptCore.xcodeproj does not have a valid extension.

It would have been nice if we had checked the version info and printed something like "You need at 
least Xcode 2.1 installed to build WebKit", perhaps even provided a URL: http://developer.apple.com/
tools/xcode

This would be pretty easy to do using "xcodebuild -version" and a bit of regex.

Maybe I'll do that right now. ;-)

[Eric Seidel (no email)]

Created attachment 3220 [details]
A patch to make build-* scripts check os & xcode version

[Eric Seidel (no email)]

Created attachment 3222 [details]
Patch to add checking Xcode & OS X version to build-* scripts.

[Darin Adler]

Comment on attachment 3222 [details]
Patch to add checking Xcode & OS X version to build-* scripts.

This:

    if (substr($buildVersion, 0, 1) < 8)

should just be $buildVersion < 8. The current version won't work for 10, for
example, and there's no reason to go out of the way to do substr.

But this looks fine, r=me.