Bug 42787

Summary:

The transaction callback parameter of db.changeVersion() should be optional

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, hausmann, michaeln

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	dumi: commit-queue-
patch	ojan: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-07-21 14:25:45 PDT

The spec says that the third parameter of db.changeVersion() (the transaction callback) is optional. It is currently mandatory in WebCore.

Attachments
patch (8.90 KB, patch) 2010-07-21 15:25 PDT, Dumitru Daniliuc	dumi: commit-queue-	Details Formatted Diff Diff
patch (10.89 KB, patch) 2010-07-21 15:30 PDT, Dumitru Daniliuc	ojan: review+ dumi: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-07-21 15:25:25 PDT

Dumitru Daniliuc

Comment 2 2010-07-21 15:30:30 PDT

Created attachment 62240 [details] patch same patch, forgot to make some minor changes to the v8 bindings.

Dumitru Daniliuc

Comment 3 2010-07-22 13:57:27 PDT

landed: r63910.

Simon Hausmann

Comment 4 2010-09-24 07:34:33 PDT

<cherry-pick-for-backport: r63910>

Simon Hausmann

Comment 5 2010-09-24 07:35:07 PDT

Revision r63910 cherry-picked into qtwebkit-2.1 with commit 8e0cd1b <http://gitorious.org/webkit/qtwebkit/commit/8e0cd1b>

Note You need to log in before you can comment on or make changes to this bug.